magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.07k stars 683 forks source link

Wrapping FormatMessage Component with <div> so that browser translate… #4355

Open del15881 opened 1 day ago

del15881 commented 1 day ago

…d DOM will not fail the js DOM Manipulation.

Description

Fixing the Login and Create Account issues faced during DOM manipulation when the store front is translated to other languages using Browser Translations. There is also 1 more change that is needed which is at file path "packages/venia-ui/lib/components/MiniCart/miniCart.js". This required change is already found in PR : https://github.com/magento/pwa-studio/pull/4318 . Check Commit ID : bbd3fb3dfc494c07b173e0e0533a07ac5f94a22b

Related Issue

Closes #PWA-3378 https://jira.corp.adobe.com/browse/PWA-3378

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

pwa-studio-bot commented 1 day ago
Messages
:book: Associated JIRA tickets: [PWA-3378](https://jira.corp.magento.com/browse/PWA-3378).
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book: Access a deployed version of this PR [here](https://pr-4355.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by :no_entry_sign: dangerJS against 9b49d3177085d212e7a800b3ce4f317b47202b09