UAT: Site Header is not Sticky

magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.

https://developer.adobe.com/commerce/pwa-studio/

Open Software License 3.0

1.07k stars 684 forks source link

UAT: Site Header is not Sticky #698

Closed awilcoxa closed 5 years ago

awilcoxa commented 5 years ago

The current site header is not sticky throughout the entire Venia storefront. The site header should be sticky and should be in view during scroll interactions according to design spec. Issue applies to all pages.

Issue 16: https://wiki.corp.magento.com/display/FF/Venia+UX+Issues

This issue is for the following packages:

[ x] venia-concept
[ ] pwa-buildpack
[x ] peregrine
[ ] pwa-devdocs
[ ] upward-js
[ ] upward-spec

This issue is a:

[x ] Bug
[ ] Feature suggestion
[ ] Documentation issue
[ ] Other (Please Specify)

Starotitorov commented 5 years ago

@awilcoxa, it seems that the page does not exist or I do not have permissions to view it https://wiki.corp.magento.com/display/FF/Venia+UX+Issues

awilcoxa commented 5 years ago

@Starotitorov the page doesn't have any additional information on this issue that isn't already contained here in the ticket. The invision prototype has additional screens for the concept of the "sticky header" see here: https://magento.invisionapp.com/share/YMO2OUHX84B#/screens/320124803

the top menu/banner should be sticky during scrolling actions.

Starotitorov commented 5 years ago

@awilcoxa, thank you for the response, the bug was fixed in this pull request https://github.com/magento-research/pwa-studio/pull/711/files.

awilcoxa commented 5 years ago

Closing, PR is merged