magento / security-package

Magento Security Extensions
Open Software License 3.0
66 stars 71 forks source link

reCaptcha is added multiple times to head #21

Open sankalpshekhar opened 4 years ago

sankalpshekhar commented 4 years ago

The link to recaptchs js is added several times to head, which slightly delays the loading time of the captcha on required pages.

Preconditions

  1. Magento 2.3.2 vanilla install with sample data
  2. Google reCaptcha v2 keys created on google

Steps to reproduce

Expected result

  1. Recaptcha should only be loaded once.

Actual result

image

Rickertje commented 4 years ago

Also it is loaded (twice) on every page so also on pages where you would not expect it to be nessecary f.e. on homepage or category page.

Lain818 commented 4 years ago

same here; magento 2.3.3

fmineo commented 4 years ago

Same problem here : 2.3.2

naydav commented 4 years ago

Should be fixed in https://github.com/magento/security-package/issues/21

naydav commented 4 years ago

https://github.com/magento/security-package/pull/191

enyceedanny commented 3 years ago

Don't see this issue fixed on the latest release of Magento 2. It's still loading multiple instances of recaptcha__en.js

hewgim commented 2 years ago

Issue still exists on Magento 2.3.7-p1

@naydav - you mentioned this was fixed on 8th April 2020 ?

cdcrothers commented 1 year ago

This issue still exists in 2.4.2-p2 EE

aodreman commented 1 year ago

This issue is still present in Magento ver. 2.4.5, loading up to four times, increasing the payload of the website by about 1.4Mb

Screenshot 2023-05-31 at 12 59 29 PM
fredden commented 1 year ago

@nathanjosiah please can you reopen this so it can be investigated.

sanganinamrata commented 1 year ago

@naydav Any update on this issue? Its still happening on Magento version 2.4.1 onwards all the latest versions.

Naberdz commented 1 year ago

I have a bit different issue recaptcha lang script is being loaded multiple times. magento version 2.4.6. added manually recaptcha to our custom newsletter form.

Schermafbeelding 2023-06-23 om 15 44 18
bharanii95dev commented 11 months ago

This issue is existing in Adobe Commerce 2.4.5.P2 as well.

image

waldok commented 10 months ago

Why is this closed? It looks like the issue is still there in 2.4.6-p1.

fredden commented 10 months ago

@nathanjosiah please can you reopen this so it can be investigated.

andrewdaluz commented 6 months ago

I'm not sure if I'm getting it right but it looks like this is all coming from Google script? 2023-12-08_10-03 2023-12-08_10-04 2023-12-08_10-05 2023-12-08_10-06 2023-12-08_10-06_1 2023-12-08_10-07

So it looks like from my limited knowledge that Google APIs as cascading the calls to the same script more than 1 time. Does that make sense? And how to resolve it? Is that only google? As per first image, it looks like Magento is already loading it just ONE time and Google is adding it multiple times.