search

magento / security-package

Magento Security Extensions
Open Software License 3.0
73 stars 69 forks source link

2fa MC-30536 and MC-30537 #227

Closed nathanjosiah closed 4 years ago

nathanjosiah commented 4 years ago

Description (*)

Fixed Issues (if relevant)

  1. magento/magento2#: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

naydav commented 4 years ago

@magento run all tests

nathanjosiah commented 4 years ago

MHI failures unavoidable. Static failures are all expected from previously existing 2fa code being re-introduced.

nathanjosiah commented 4 years ago

The integration test builds are green except for a hidden issue that can only be seen in the raw logs because of Recaptcha tests not being compatible with phpunit9. This cant be fixed until 2fa is merged and security-package branches are synced. http://10.234.226.254:8080/job/Integration-Tests/3687/consoleText The build for merging 1.0-develop into 1.0.0-develop will confirm all compatibility before everything is packaged. A test PR for merging these changes into 1.0.0-develop which contains all the proper phpunit 9 compatibility already is here https://github.com/magento/security-package/pull/230

nathanjosiah commented 4 years ago

@magento run Functional Tests B2B

nathanjosiah commented 4 years ago

B2B failures due to instability of core. see https://jira.corp.magento.com/browse/MC-34516

naydav commented 4 years ago

At the moment, none of the CIA team has permissions to the merge PRs. @nathanjosiah asked me to assist with it.

So, Nathan, please make sure that all the build failures are valid, agreed with the PO and the team technical leader. Let me know when you are ready.

@okorshenko, please give someone from the CIA team the permissions to merge PRs, since 2 teams are working on this project.

nathanjosiah commented 4 years ago

@naydav I'm the team technical lead and also gatekeeper. Please add me as the admin

naydav commented 4 years ago

@nathanjosiah I had response from @okorshenko

Please use #github-permissions chat There is bot which can grant permissions CIA team manager can request these permissions

nathanjosiah commented 4 years ago

@magento run all tests

okorshenko commented 4 years ago

Permissions added

Regards, Oleksii Korshenko

Senior Manager, Head of Community Engineering

From: Nathan Smith notifications@github.com Sent: Saturday, May 23, 2020 8:39:44 PM To: magento/security-package security-package@noreply.github.com Cc: Oleksii Korshenko korshenk@adobe.com; Mention mention@noreply.github.com Subject: Re: [magento/security-package] 2fa MC-30536 and MC-30537 (#227)

@magentohttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmagento&data=02%7C01%7Ckorshenk%40adobe.com%7C03ba0bfdfcb44104a65d08d7ff83564b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637258811891441858&sdata=yinlNoHsAly7LFx3LLx3KzJzx7qkYqYihOEk%2B%2FTkIP0%3D&reserved=0 run all tests

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmagento%2Fsecurity-package%2Fpull%2F227%23issuecomment-633164225&data=02%7C01%7Ckorshenk%40adobe.com%7C03ba0bfdfcb44104a65d08d7ff83564b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637258811891451813&sdata=0xcYYm7G1rgE5hDhnL%2B7Gw%2BnVXKHBEqUrykRp1b1FnU%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABX4LE4Q7YWSZFG2T7DYHITRTB3GBANCNFSM4NIID32Q&data=02%7C01%7Ckorshenk%40adobe.com%7C03ba0bfdfcb44104a65d08d7ff83564b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637258811891451813&sdata=H4Lf%2BlTC2mO4pXCVl6sVgIy2r7x2vO0jaToDsaTzrfM%3D&reserved=0.

nathanjosiah commented 4 years ago

@magento run all tests

nathanjosiah commented 4 years ago

Full build with mysql 5.7 (8 is broken) is here https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/33070/