search

magento / security-package

Magento Security Extensions
Open Software License 3.0
73 stars 69 forks source link

Fix broken dependency test. #278

Closed swnsma closed 3 years ago

swnsma commented 3 years ago

During fixing of Dependency tests there was discovered that one of the Security Package modules has wrong dependencies.

Related PR: https://github.com/magento/magento2/pull/30331

nathanjosiah commented 3 years ago

@swnsma Can you help me understand why adding a suggest to composer fixes any dependency issues? AFAIK this doesn't change the dependency tree at all but rather just outputs a message when composer installs the package

nathanjosiah commented 3 years ago

Closing due to inactivity

swnsma commented 3 years ago

Hi @nathanjosiah, Using of 'suggest' mark dependencies which mentioned in the module and does not required for it's work: dependency in plugins, tests etc. In this extension Magento_Backend is used in tests.

magento-automated-testing[bot] commented 3 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing[bot] commented 3 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.