search

magento / security-package

Magento Security Extensions
Open Software License 3.0
73 stars 69 forks source link

Fix for issue #285 #286

Closed comdiler closed 3 years ago

comdiler commented 3 years ago

Description (*)

Email notification for 2FA configuration has a wrong link, which leads to 404 page

Fixed Issues (if relevant)

  1. magento/security-package#285: Email notification for 2FA configuration has a wrong link, which leads to 404 page

Manual testing scenarios (*)

  1. Login to admin panel
  2. Go to System - Permissions - All Users
  3. Add a new admin user
  4. Send a /rest/default/V1/integration/admin/token POST request with username and password from step 3 You will get a response about email notification has been sent image
  5. Check received email and click the link image image
  6. Link should lead to the 2FA settings page

Contribution checklist (*)

nathanjosiah commented 3 years ago

@magento import code to https://github.com/magento-commerce/security-package

nathanjosiah commented 3 years ago

@magento import code to https://github.com/magento-commerce/security-package

magento-engcom-team commented 3 years ago

@nathanjosiah the branch with code successfully imported intomagento-commerce/security-package repository. Branch name: imported-magento-security-package-286.

nathanjosiah commented 3 years ago

I had to change the namespace in the WebApiUserNotifier as well. While I was in there I also added a few tests for automated coverage.