search

magento / security-package

Magento Security Extensions
Open Software License 3.0
66 stars 69 forks source link

Mark interfaces and blocks as API #290

Closed sivaschenko closed 2 years ago

sivaschenko commented 3 years ago

The following interfaces and blocks should be marked as API in future-develop branch

  1. security-package/TwoFactorAuth/Api/AdminTokenServiceInterface.php
  2. security-package/TwoFactorAuth/Api/AuthyAuthenticateInterface.php
  3. security-package/TwoFactorAuth/Api/AuthyConfigureInterface.php
  4. security-package/TwoFactorAuth/Api/CountryRepositoryInterface.php
  5. security-package/TwoFactorAuth/Api/Data/AdminTokenResponseInterface.php
  6. security-package/TwoFactorAuth/Api/Data/AuthyDeviceInterface.php
  7. security-package/TwoFactorAuth/Api/Data/AuthyRegistrationPromptResponseInterface.php
  8. security-package/TwoFactorAuth/Api/Data/CountryInterface.php
  9. security-package/TwoFactorAuth/Api/Data/CountrySearchResultsInterface.php
  10. security-package/TwoFactorAuth/Api/Data/DuoDataInterface.php
  11. security-package/TwoFactorAuth/Api/Data/GoogleAuthenticateInterface.php
  12. security-package/TwoFactorAuth/Api/Data/GoogleConfigureInterface.php
  13. security-package/TwoFactorAuth/Api/Data/U2fWebAuthnRequestInterface.php
  14. security-package/TwoFactorAuth/Api/Data/UserConfigInterface.php
  15. security-package/TwoFactorAuth/Api/Data/UserConfigSearchResultsInterface.php
  16. security-package/TwoFactorAuth/Api/DuoAuthenticateInterface.php
  17. security-package/TwoFactorAuth/Api/DuoConfigureInterface.php
  18. security-package/TwoFactorAuth/Api/EngineInterface.php
  19. security-package/TwoFactorAuth/Api/Exception/NotificationExceptionInterface.php
  20. security-package/TwoFactorAuth/Api/GoogleAuthenticateInterface.php
  21. security-package/TwoFactorAuth/Api/GoogleConfigureInterface.php
  22. security-package/TwoFactorAuth/Api/ProviderInterface.php
  23. security-package/TwoFactorAuth/Api/ProviderPoolInterface.php
  24. security-package/TwoFactorAuth/Api/TfaInterface.php
  25. security-package/TwoFactorAuth/Api/TfaSessionInterface.php
  26. security-package/TwoFactorAuth/Api/TfatActionsInterface.php
  27. security-package/TwoFactorAuth/Api/U2fKeyAuthenticateInterface.php
  28. security-package/TwoFactorAuth/Api/U2fKeyConfigReaderInterface.php
  29. security-package/TwoFactorAuth/Api/U2fKeyConfigureInterface.php
  30. security-package/TwoFactorAuth/Api/UserConfigManagerInterface.php
  31. security-package/TwoFactorAuth/Api/UserConfigRepositoryInterface.php
  32. security-package/TwoFactorAuth/Api/UserConfigRequestManagerInterface.php
  33. security-package/TwoFactorAuth/Api/UserConfigTokenManagerInterface.php
  34. security-package/TwoFactorAuth/Api/UserNotifierInterface.php
  35. security-package/TwoFactorAuth/Model/AlertInterface.php
  36. Magento\TwoFactorAuth\Block\ConfigureLater
  37. Magento\TwoFactorAuth\Block\Configure
  38. Magento\TwoFactorAuth\Block\Provider\U2fKey\Configure
  39. Magento\TwoFactorAuth\Block\Provider\U2fKey\Auth
m2-assistant[bot] commented 3 years ago

Hi @sivaschenko. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

nathanjosiah commented 3 years ago

@magento export issue to Jira project MC as Story

github-jira-sync-bot commented 3 years ago

:white_check_mark: Jira issue (https://jira.corp.magento.com/browse/MC-40870) is successfully created for this issue.

AndreyChorniy commented 3 years ago

@magento I am working on this

nathanjosiah commented 2 years ago

fixed in https://github.com/magento-commerce/security-package/pull/38

fredden commented 2 years ago

fixed in https://github.com/magento-commerce/security-package/pull/38

https://github.com/magento/security-package/commit/8d5c176194b535f379d985d130d6999edb08e00d