magento / security-package

Magento Security Extensions
Open Software License 3.0
66 stars 69 forks source link

290 - Mark interfaces as api, refactoring interfaces #294

Closed AndreyChorniy closed 2 years ago

AndreyChorniy commented 3 years ago

Description (*)

This PR created to mark interfaces as api, also added small code refactoring changes

Fixed Issues (if relevant)

  1. magento/security-package#290 Mark interfaces and blocks as API

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

AndreyChorniy commented 3 years ago

@magento run all tests

nathanjosiah commented 3 years ago

@magento run all tests against 2.4.3-develop

magento-automated-testing[bot] commented 3 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

nathanjosiah commented 3 years ago

@AndreyChorniy Can you pull the latest code into your branch. I think that's the bulk of the failures in the builds.

nathanjosiah commented 3 years ago

@magento import code to https://github.com/magento-cia/security-package

nathanjosiah commented 3 years ago

@magento import code to https://github.com/magento-commerce/security-package

nathanjosiah commented 3 years ago

@magento import code to https://github.com/magento-commerce/security-package

magento-engcom-team commented 3 years ago

@nathanjosiah the branch with code successfully imported intomagento-commerce/security-package repository. Branch name: imported-magento-security-package-294.

fredden commented 2 years ago

https://github.com/magento/security-package/commit/8d5c176194b535f379d985d130d6999edb08e00d