search

magento / security-package

Magento Security Extensions
Open Software License 3.0
66 stars 69 forks source link

Fix check if place-order-recaptcha component is set #302

Closed basvanpoppel closed 2 years ago

basvanpoppel commented 2 years ago

…ptcha-container

Description (*)

The place-order-recaptcha component is set within the place-order-recaptcha-container. The check was looking for the component on the wrong place - therefor the component was loaded while recaptcha was disabled.

Fixed Issues (if relevant)

  1. magento/magento2#33741: JS error in console on checkout when if recaptcha for checkout/placing order is not enabled

Manual testing scenarios (*)

  1. Make sure 'Stores > Configuration > Security > Google reCAPTCHA Storefront > Storefront > Enable for Checkout/Placing Order' is set to 'No'
  2. Add a product to cart
  3. Go to checkout
  4. Open element inspector, no JS error. (or check source: no place-order-recaptcha component in js layout)

Questions or comments

Do I need to add a unit test here? The fix is simple. Please let me know if anything else is needed.

Contribution checklist (*)

magento-automated-testing[bot] commented 2 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

nathanjosiah commented 2 years ago

@tuna2smc @basvanpoppel Are you still working on this PR?

basvanpoppel commented 2 years ago

@nathanjosiah the PR is ready for review. Is there anything I can do?

nathanjosiah commented 2 years ago

Approved from my end, before I can process this PR please pull latest develop and stabilize your builds.

nathanjosiah commented 2 years ago

@basvanpoppel Are you able to stabilize your PR?

basvanpoppel commented 2 years ago

Hi @nathanjosiah

Sorry for the late reply, i was away for a few weeks and forgot to reply. I've updated my branch, all looks fine now.

nathanjosiah commented 2 years ago

@magento run all tests

magento-automated-testing[bot] commented 2 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

nathanjosiah commented 2 years ago

@magento import pr to https://github.com/magento-commerce/security-package

nathanjosiah commented 2 years ago

@magento import pr to https://github.com/magento-commerce/security-package

m2-github-services commented 2 years ago

@nathanjosiah the Pull Request is successfully imported.

nathanjosiah commented 2 years ago

Merged via https://github.com/magento-commerce/security-package/pull/54

Aquive commented 2 years ago

In which version of Magento is or will this be fixed?

nathanjosiah commented 2 years ago

@Aquive the fix is merged and will be part of 2.4.4 which is scheduled to GA March 8 2022