Updated endroid/qr-code to 4.3.5

anzin commented 2 years ago

Description (*)

Updated endroid/qr-code dependency to the latest version (4.3.5).

Fixed Issues (if relevant)

magento/magento2#34101

Contribution checklist (*)

[ ] Author has signed the Adobe CLA
[ ] Pull request has a meaningful description of its purpose
[ ] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] All automated tests passed successfully (all builds are green)

andrewbess commented 2 years ago

@magento run all tests with env PHP 8.0

magento-automated-testing[bot] commented 2 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess commented 2 years ago

@magento run all tests

magento-automated-testing[bot] commented 2 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

xmav commented 2 years ago

@anzin Could you please do smoke manual test to verify changed code ?

anzin commented 2 years ago

@magento run all tests with env PHP 8.0

magento-automated-testing[bot] commented 2 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

anzin commented 2 years ago

@magento run all tests

magento-automated-testing[bot] commented 2 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess commented 2 years ago

@magento run Functional Tests B2B, Functional Tests EE, WebAPI Tests with env PHP 8.0

magento-automated-testing[bot] commented 2 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess commented 2 years ago

@magento run Functional Tests EE

magento-automated-testing[bot] commented 2 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

xmav commented 2 years ago

test build with new library dependency is in progress

xmav commented 2 years ago

Hi @anzin! Please fix static tests failure:

1) Magento\Test\Php\LiveCodeTest::testCodeMess
PHP Code Mess has found error(s):
/var/www/html/app/code/Magento/TwoFactorAuth/Test/Unit/Model/Provider/Engine/GoogleTest.php:25  The class GoogleTest has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.

All other tests passed on env with new library

anzin commented 2 years ago

@magento run Static Tests

magento-automated-testing[bot] commented 2 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

xmav commented 2 years ago

@magento import pr to magento-commerce

xmav commented 2 years ago

@magento import pr to magento-commerce/security-package

m2-github-services commented 2 years ago

@xmav the Pull Request is successfully imported.

magento / security-package