magento / security-package

Magento Security Extensions
Open Software License 3.0
73 stars 69 forks source link

Wrong version in 1.1.3-p1 metapackage composer.json #321

Closed Vinai closed 2 years ago

Vinai commented 2 years ago

Preconditions (*)

The version in the compser.json of the 1.1.3-p1 tag release metapackage wasn't updated.

Expected version: 1.1.3-p1 Actual version: 1.1.3

Reference https://github.com/magento/security-package/blob/1.1.3-p1/_metapackage/composer.json#L5

This causes issues with tooling expecting the version in the composer.json file to match the composer package.

m2-assistant[bot] commented 2 years ago

Hi @Vinai. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


damienwebdev commented 2 years ago

This winds up with:

  Problem 1
    - Root composer.json requires magento/product-community-edition 2.4.4-p1 -> satisfiable by magento/product-community-edition[2.4.4-p1].
    - magento/product-community-edition 2.4.4-p1 requires magento/security-package 1.1.3-p1 -> found magento/security-package[1.0.0, ..., 1.1.4] but it does not match the constraint.
nathanjosiah commented 2 years ago

The versions have been fixed and resynced

damienwebdev commented 2 years ago

Thank you @nathanjosiah !