search

magentos-pl / opencaching-pl

Automatically exported from code.google.com/p/opencaching-pl
0 stars 0 forks source link

Incomplete baloon on oc.nl and oc.ro #161

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I notice that on map V3 the balloon on the Dutch oc site is incomplete. (Also 
on oc.ro)

On the Dutch balloon there is no "rated" line and there is no green + sign to 
add this cache to the clipboard list.

Original issue reported on code.google.com by henricus...@gmail.com on 22 Sep 2014 at 8:56

Attachments:

GoogleCodeExporter commented 9 years ago 
In /lib/cachemap3.js on line 690 "if (wp_check=="OP") {" does hardcoded "OP" 
make that no other node get the green + sign in the balloon. I have temporarily 
changed it on oc.nl to "OB".
Can please some one change this line in cachemap3.js so it does not only use 
"OP" waypoints?

Thanks.

Original comment by henricus...@gmail.com on 20 Oct 2014 at 11:03

GoogleCodeExporter commented 9 years ago 
Found also in /lib/cachemap3.js on line 705 "if (node == 2)" and this makes 
that the times rated is not visible. I have temporarily changed it on oc.nl to 
(node == 14).

Can this also be changed to make it work on each node?

Thanks.

Original comment by henricus...@gmail.com on 5 Dec 2014 at 7:27

GoogleCodeExporter commented 9 years ago 
Hmm, is these conditions useable at all? I think, you can remove it, and test.

step 0: 
missing { } witch condition is a bad practice, and {} should be present always.
before you start your test I suggest add {} for condition #705 - 706 to keep 
code more clear, more readable for yourself.

replace:

if (node == 2)
     infoWindowContent += "<nobr>< (... more code here ...) ;

witch 

if (node == 2) {
     infoWindowContent += "<nobr>< (... more code here ...) ;
}

at the first step, try temporary replace both conditions with true. example:
replace 

if (wp_check=="OP"){

witch 

if(true) {

Then test it local, if work fine, you may commit and test on all nodes. If all 
will be OK goto step 2

step 2: 
you can permanent remove conditions:

example:

replace
if (true){
     (some code here)
} else {
   (alter code here)
}

witch

(some code here)

- Be carefull to remove proper { },  do not mess code block inside { }

Original comment by wloczynutka on 5 Dec 2014 at 10:20

GoogleCodeExporter commented 9 years ago 
Changed mentioned lines with {old code} to {true}. This works fine.

Thanks for the help :-)

Original comment by henricus...@gmail.com on 5 Dec 2014 at 11:12