search

magepal / magento2-gmail-smtp-app

Configure Magento 2 to send email using Google App, Gmail, Amazon Simple Email Service (SES), Microsoft Office365 and many other SMTP (Simple Mail Transfer Protocol) servers
https://www.magepal.com
319 stars 147 forks source link

Use factory to load correct smtp model #134

Closed JeroenVanLeusden closed 2 years ago

JeroenVanLeusden commented 5 years ago

This will allow the usage of plugins on the sendSmtpMessage method.

srenon commented 5 years ago

@JeroenVanLeusden ... .Thanks for the PR.

Did you test this code on Magento 2.1.x, 2.2.x and 2.3.x, I was expecting to get a di:compile error since the class extended should not exist on some version; hence why I hard coded it.

Give me a few review since I did some code refactoring since

JeroenVanLeusden commented 5 years ago

@srenon Only tested this on 2.3 where di:compile worked as expected.

srenon commented 2 years ago

@JeroenVanLeusden .... I'm going to close this because with 2.4.4 I will have to remove older support