search

magepal / magento2-gmail-smtp-app

Configure Magento 2 to send email using Google App, Gmail, Amazon Simple Email Service (SES), Microsoft Office365 and many other SMTP (Simple Mail Transfer Protocol) servers
https://www.magepal.com
319 stars 148 forks source link

Added Dependencies #148

Closed DavidLambauer closed 2 years ago

srenon commented 4 years ago

@DavidLambauer... Thanks for the PR, but is there a particular issue you are trying to solve by adding more module dependencies?

For example, Magento_Email already depend on Magento_Store.. https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Email/etc/module.xml and the rest should not really care about or affect module load order

DavidLambauer commented 4 years ago

Hey, just had problems with dependency list in total, so I decided to go through my custom modules and check if all dependencies are declared correctly.

srenon commented 2 years ago

@DavidLambauer ... thanks for the PR