search

magepal / magento2-google-tag-manager

Google Tag Manager is a user-friendly, yet powerful and cost-effective solution that is a must-have integration for every Magento store. It simplifies the process of adding and managing third-party JavaScript tags. With dozens of custom events and hundreds of data points our extensions the #1 GTM solution for Magento.
https://www.magepal.com/google-tag-manager.html
259 stars 89 forks source link

GDPR Compliance #53

Closed simonmaass closed 5 years ago

simonmaass commented 5 years ago

we added this little code in order to be gdpr compliante... and only load the GTM if the user accepted the cookies..

srenon commented 5 years ago

@simonmaass .... not sure why you close the PR but I'm already in the process of adding similar functionality. However, I will add the ability for the store owner to choose if they want to include the GTM code in the header or load it using JS which could be few milli-seconds slow and affect page loading status

simonmaass commented 5 years ago

@srenon sorry - that was a missclick...

srenon commented 5 years ago

@simonmaass.. Thanks for the PR, I release a new version with some of your code. The merge conflict would have taken too long resolve so it was easier to cut and paste logic as need.

Thanks.

simonmaass commented 5 years ago

great to know :)!