mageprakash / OrderAttachment

Magento 2 Order Attachment by MagePrakash allows customers to attachments proof such as Images, PDFs or any type of Files/Docs while placing the orders.
18 stars 9 forks source link

Backend Users With Restricted Accounts Cannot Upload Attachments #12

Closed sprankhub closed 4 years ago

sprankhub commented 4 years ago

In the controllers, you define an ADMIN_RESOURCE, which is good:

https://github.com/prakash282/OrderAttachment/blob/88e921d0b7fe94c7637b77a215ea86191db3c115/Controller/Adminhtml/Attachment/Upload.php#L9

However, this resource is not defined anywhere. Hence, only full admin accounts can upload images. The used resources need to be defined in etc/acl.xml, so that they can be configured correctly.

BorisovskiP commented 4 years ago

PR provided for the fix : https://github.com/prakash282/OrderAttachment/pull/14

sprankhub commented 4 years ago

Fixed in #16.

mageprakash commented 4 years ago

Thank you Borisovskip for contribution