Closed sprankhub closed 4 years ago
In your screenshots like https://user-images.githubusercontent.com/10853368/62530323-eda51880-b85d-11e9-83be-be3cbd403f77.png, a download button is shown next to the delete button. However, this download button is not present. The CSS for the icon is still defined:
https://github.com/prakash282/OrderAttachment/blob/88e921d0b7fe94c7637b77a215ea86191db3c115/view/base/web/css/orderattachment.css#L64
However, the actual HTML element is not included.
When doing this, it is important that the file is downloaded via a custom URL and not only linked to https://www.store.tld/media/orderattachment/f/i/file.pdf for security reasons.
Fixed in #17.
sprankhub
commented
4 years ago
In your screenshots like https://user-images.githubusercontent.com/10853368/62530323-eda51880-b85d-11e9-83be-be3cbd403f77.png, a download button is shown next to the delete button. However, this download button is not present. The CSS for the icon is still defined:
https://github.com/prakash282/OrderAttachment/blob/88e921d0b7fe94c7637b77a215ea86191db3c115/view/base/web/css/orderattachment.css#L64
However, the actual HTML element is not included.
When doing this, it is important that the file is downloaded via a custom URL and not only linked to https://www.store.tld/media/orderattachment/f/i/file.pdf for security reasons.