search

mageprince / magento2-FAQ

This module adds an easy way to use FAQ Section to your Magento store with jQuery Accordion. In this module, admin can add and update FAQ. Admin can also create FAQ group with group icon.
57 stars 37 forks source link

FAQ Url Rewrite #30

Closed trucatchtraps closed 4 years ago

trucatchtraps commented 4 years ago

Latest version 1.0.7. Every time you Save Config for the FAQ settings, it creates a URL Rewrite which points to the URL you had set before so it gets stuck in a loop. Deleting the URL Rewrite fixes the issue, but you should not have to do that.

mageprince commented 4 years ago

@trucatchtraps Thank you for posting an issue. There is only one URL rewrite generated. If admin re-save FAQ configuration it's finds for the same URL to replace with a new custom FAQ URL.

The reason for adding URL rewrite is, Magento Marketplace raised the issue like the main faq URL should not work after adding custom URL. So we add these URL rewrites to redirect the main URL to custom URL.

trucatchtraps commented 4 years ago

Correct, but you have to remove the URL Rewrite otherwise the page will try to load in an infinite loop. Remove the URL Rewrite and the page loads just fine. As soon as you save the Config again, it creates the URL Rewrite again, which I then have to delete to view the FAQ page.

mageprince commented 4 years ago

@trucatchtraps The issue has been resolved now. Please check the commit: 8c9bde2e or download latest repository.