search

magesuite / magepack

Next generation Magento 2 advanced JavaScript bundler.
Open Software License 3.0
438 stars 91 forks source link

Vimeo js configs aren't being generated properly #173

Open toan-tam opened 1 year ago

toan-tam commented 1 year ago

Hi,

I'm seeing that the Vimeo js files aren't being merged into the bundle files. I belive it's because magepack isn't generating the config properly for Vimeo js files as I'm seeing these lines in the magepack.config.js file.

      'vimeo/player': 'vimeo/player/player',
      'vimeo/vimeo-wrapper': 'vimeo/player/vimeo-wrapper',

I am able to fix this temporarily by removing the player path in the config as below:

      'vimeo/player': 'vimeo/player',
      'vimeo/vimeo-wrapper': 'vimeo/vimeo-wrapper',

I'm using magepack 2.11.2 on Magento Commerce 2.4.5.

Can we get this fixed so that the magepack generate command can collect these Vimeo JS files config properly?

Thanks!

MaximGns commented 1 year ago

+1