search

magesuite / theme-creativeshop

Open Software License 3.0
38 stars 24 forks source link

PDP forms after clicking "Submit" are open in sidebar modal, and then moved to buybox container #32

Closed jtomaszewski closed 3 years ago

jtomaszewski commented 3 years ago

Either we're overwriting some code incorrectly, or https://github.com/magesuite/theme-creativeshop/commit/1fde59a5260bbbcf3601794f02b71f2b2a3adcf3#diff-3819ee66c6b898de866920657ce39e5a5eeb14ed53d27cc29945e694982867fbR16 caused a regression which makes forms like "Write review" be open in a modal. After modal is closed, then they are moved to buybox container, even if they had been placed originally in a different place:

Before submit image

After submit image

After submit and closing the modal image

BTW. Do you plan to update https://demo.magesuite.io/ so that it uses the newest theme-creativeshop? Then it would be easier to see if the bug is in theme-creativeshop or at our side.

jtomaszewski commented 3 years ago

As a workaround, one can put the following in their theme src/requirejs-config.js:

var config = {
    config: {
        mixins: {
            'Magento_Catalog/js/validate-product': {
                'Magento_Catalog/js/swatches-validation-ext': false,
            },
        },
    },
};

However this will disable the Swatch Modal on category listing pages as well, which ain't nice.

jtomaszewski commented 3 years ago

Should be fixed with https://github.com/magesuite/theme-creativeshop/commit/9d15f50e49dcebe03a86c35486d4547ac7eec473#diff-5cae78774dd2367a5672c8fcd4f296cabc9af5683d8199ebcb5544d0a9a9d56b .