search

magesuite / theme-creativeshop

Open Software License 3.0
38 stars 24 forks source link

fix(swatch-renderer-ext): Only display/hide price tooltips of the clicked product tile cell, not of all cells #50

Open jtomaszewski opened 3 years ago

jtomaszewski commented 3 years ago

When user is on a product listing page (e.g. category), and there are products with swatches, then the product has "From xxx" price. If user selects swatch, the price should change to "xxx" (the "From" word should disappear), but only for that one product.

However currently that "From" is hidden on all product tiles.

This commit fixes it.

For more info, see videos:

Before the change:

https://user-images.githubusercontent.com/1862580/103486100-86e1b100-4dfb-11eb-8016-9e76e499cdc8.mov

After the change:

https://user-images.githubusercontent.com/1862580/103486109-8ea15580-4dfb-11eb-88d1-5a4e11acc64a.mov

msiewierska commented 3 years ago

@jtomaszewski Do you use the newest version of theme-creativeshop? It seems that the issue was fixed before internally. Please check if this commit fixed the issue: https://github.com/magesuite/theme-creativeshop/commit/711c8a55030d9863e7c00fb925e887d799727d74#diff-d8a8e4fae40dc6faf5826ec6c64af7c7c735b0223393d259fd1b5f358509872e

jtomaszewski commented 3 years ago

We are... and we still need that workaround. Maybe it's because we also use magesuite/server-side-swatches ? Or maybe it's because of some other swatch-related plugin that we're also using... hard to tell.