magey / classic-warrior

109 stars 9 forks source link

Offhand damage calculation #18

Open krangerich opened 5 years ago

krangerich commented 5 years ago

Don't know, if this is relevant or belongs here, but while building my warrior spreadsheet, I noticed the following:

When calculating the min/max damage from a offhand weapon, the attack power used in this calculation is being rounded to the next multiple of 4.

Basic formula (without talents for simplicity): oh_min_dmg = (attack_power/14oh_speed + oh_min_weapon_dmg) 50%

387, 388 or 389 attack power will lead to the same value (determined using UnitDamage("player")).

Mainhand damage doesn't seem to be affected this way

Malchar commented 5 years ago

Based on some limited testing on Kronos 3, I believe that the formula on Kronos 3 might be something like this:

oh_min_dmg = floor(oh_min_weapon_dmg * 50%) + floor(attack_power / 14 * oh_speed * 50%)

I haven't thought about it too hard, but it's possible that flooring both components separately could account for the strange "multiple of 4" rounding.