search

magey / classic-warrior

109 stars 9 forks source link

Shield equip triggering GCD in combat #28

Open lvangh opened 5 years ago

lvangh commented 5 years ago

Not sure if this is OG 1.12 Blizz-like, but in the beta equipping a shield in combat triggers GCD. Shields are considered weapons, but maybe this is an oversight and shield should be excluded (I hope).

Cleavis commented 5 years ago

example testing video of OP-described behavior from beta (swapping DW offhand -> shield in combat triggers GCD)

https://youtu.be/FB7vWJwF9jU

Cleavis commented 5 years ago

Is NOT what OP is looking for, but references for 2H swap to 1H+Shield in combat triggers GCD in vanilla:

https://youtu.be/aexOzB5YHSw?t=612 at 10:15 swaps to 1H+Shield while bandaging, triggering the GCD on his bars. Is in combat from Bloodrage.

https://youtu.be/nOIoPAUCXpk?t=131 at 2:16 swaps from 1H+Shield to 2H, triggering GCD on bars. Is in active combat and Bloodrage is active.

(Still looking for vanilla reference for DW->Shield.)

lvangh commented 5 years ago

I did some more testing on this.

If you are --already ON-- GCD, you can still equip a shield, and it will reset GCD timer. e.g. you cast BT then spam the shield, it will equip and 'add' to your GCD time.

If you are OFF GCD, equipping a shield still triggers GCD in the last beta.