magey / classic-warrior

109 stars 9 forks source link

How SoD deep wounds works #33

Open GuybrushGit opened 10 months ago

GuybrushGit commented 10 months ago

Currently on SoD the deep wounds debuff is "storing" its damage upon application, meaning that additional crits will add their damage to the stored value of an already existing deep wounds debuff.
This has the side effect of causing a double dip of damage modifiers, once when the damage is stored and again when the damage is dealt. The damage modifier from Mangle does NOT double dip.

Some examples, assuming you have 3/3 talent points and 60% of your weapon is 80:

1 single crit Melee attack crits Deep wounds is applied (80 damage stored) Tick for 20 damage (60 damage stored) Tick for 20 damage (40 damage stored) Tick for 20 damage (20 damage stored) Tick for 20 damage (0 damage stored)

Double crit Melee attack crits Deep wounds is applied (80 damage stored) Melee attack crits Deep wounds is refreshed (160 damage stored) Tick for 40 damage (120 damage stored) Tick for 40 damage (80 damage stored) Tick for 40 damage (40 damage stored) Tick for 40 damage (0 damage stored)

Single crit with another crit later on Melee attack crits Deep wounds is applied (80 damage stored) Tick for 20 damage (60 damage stored) Tick for 20 damage (40 damage stored) Melee attack crits Deep wounds is refreshed (40 + 80 = 120 damage stored) Tick for 120 / 4 = 30 damage (90 damage stored) Tick for 30 damage (60 damage stored) Tick for 30 damage (30 damage stored) Tick for 30 damage (0 damage stored)

1 single crit with a 20% enrage buff Enrage buff applied Melee attack crits Deep wounds is applied (80 * 1.2 = 96 stored) Each tick should be only 96 / 4 = 24 from now on, but the damage modifier is being added again: Tick for 24 * 1.2 = 28.8 damage (72 stored) Tick for 28.8 damage (48 stored) Enrage buff expires Tick for 24 damage (24 stored) Tick for 24 damage (0 stored)

zheamourth commented 10 months ago

This is also occurring with flagellation

GuybrushGit commented 9 months ago

SoD phase 2 deep wound changes: