magey / tbc-warrior

10 stars 1 forks source link

Proc rates of vanilla items at 70 #19

Open Scyllaqt opened 3 years ago

Scyllaqt commented 3 years ago

It's expected that the proc rate of level 60 and below items will scale down as you level up, leading to a 1/3 lower proc rate at 70 than if you were level 60 using the item.

Items to test:

For Nightfall specifically, there's an added chance to fail on targets that are above lvl 60 that blizzard put in to prevent it being used on Brutallus. According to this EJ Thread, Nightfall has less than a .1% chance to proc on targets around lvl 70.

some sources that this behavior exists:

Skullflame Shield wowhead image

Deadman's Hand image https://web.archive.org/web/20080212184457/http://forums.worldofwarcraft.com/thread.html?topicId=2366692968&postId=23663923413&sid=1 image

cannonpalms commented 3 years ago

In addition to proc rate, need to test Skullflame's spell damage scaling. It allegedly should have 100% scaling https://github.com/Atlantiss/NetherwingBugtracker/issues/5130.

cannonpalms commented 3 years ago

Skullflame testing from beta: https://www.warcraftlogs.com/reports/wQxTacLGBf1mMZXJ/#fight=1&source=3&type=damage-done&ability=18817&view=events

Gear: image

Proc rate needs a bigger sample size.

Cleavis commented 3 years ago

observed proc rate of thunderfury AT LEVEL 60 in tbc beta (for comparison's sake) is 19.4% +/- 1.2% https://classic.warcraftlogs.com/reports/Hvf7yc9XWg4aVdAJ/#fight=last&source=3&type=damage-done

Appears unchanged from classic's 19.17% (6PPM).

magey commented 3 years ago

Badge of the Swarmguard

We did some tests both at level 60 on the Classic PTR and at level 70 on the BCC beta:

Level 60 on the Classic PTR (1.13.7), using a 2.70 speed weapon:

Name Hits Procs Chance (95% CI) PPM (95% CI)
Insight of the Qiraji 611 293 47.95% ±3.96% 10.656 ±0.880

Level 70 on the BCC beta, using a 3.50 speed weapon:

Name Hits Procs Chance (95% CI) PPM (95% CI)
Insight of the Qiraji 641 383 59.75% ±3.80% 10.243 ±0.651

It seems the PPM is completely unaffected by level scaling. Next up we're going to test whether the armor penetration effect gives the amount stated on the tooltip or if it scales down with level.

magey commented 3 years ago

Hand of Justice

We tested HoJ at level 70 on the beta:

Name Hits Procs Chance (95% CI) MTBP
Hand of Justice 9656 120 1.24% ±0.22% 6.032s

Level scaling of the proc chance seems to be in effect here. Additionally, it seems the ICD also scales up with level; it was around 6s in two HoJ logs collected by two different players. We also measured the ICD at level 60 on the beta for control and it was ~2s, just like in classic.