search

magey / tbc-warrior

10 stars 1 forks source link

Sword Specialization is resetting the swing timer #31

Closed magey closed 3 years ago

magey commented 3 years ago

Sword Specialization was changed in patch 2.1.3 to not reset your swing timer when it procs:

  * Sword Specialization: The change to Sword Specialization making its
    extra attacks appear in yellow has been reverted. Extra attacks will
    appear in white and act like any auto-attack. They will no longer
    reset the swing time of your weapon. Rage awarded will be calculated
    by damage dealt as with any normal auto-attack.

Currently on the beta it still resets your swing timer. Example log (abridged version):

3/27 04:47:05.307  SWING_DAMAGE
3/27 04:47:05.307  SWING_DAMAGE_LANDED
3/27 04:47:06.104  SPELL_CAST_SUCCESS,"Hamstring"
3/27 04:47:06.104  SPELL_EXTRA_ATTACKS,"Sword Specialization"
3/27 04:47:06.104  SPELL_DAMAGE,"Hamstring"
3/27 04:47:06.104  SPELL_AURA_REFRESH,"Hamstring"
3/27 04:47:06.104  SWING_DAMAGE
3/27 04:47:06.104  SWING_DAMAGE_LANDED
3/27 04:47:06.104  SPELL_AURA_REFRESH,"Deep Wound"
3/27 04:47:08.222  SWING_DAMAGE
3/27 04:47:08.222  SWING_DAMAGE_LANDED

In this log I'm using a 2.1 speed Gladius. Normal swing happens at 04:47:05.307, followed by a Sword Specialization proc off of Hamstring at 04:47:06.104. The next swing should occur at 04:47:05.307 + 2.1 = 04:47:07.407 but instead it happens at 04:47:08.222 which is 2.116s after the Sword Specialization extra attack.

Scyllaqt commented 3 years ago

still occuring in build 2.5.1.38339

4/19 12:50:17.882  SWING_DAMAGE
4/19 12:50:17.882  SWING_DAMAGE_LANDED
4/19 12:50:20.570  SPELL_CAST_SUCCESS,"Hamstring"
4/19 12:50:20.570  SPELL_EXTRA_ATTACKS,"Sword Specialization"
4/19 12:50:20.570  SPELL_DAMAGE,"Hamstring"
4/19 12:50:20.570  SWING_DAMAGE
4/19 12:50:20.570  SWING_DAMAGE_LANDED
4/19 12:50:23.987  SWING_MISSED
magey commented 3 years ago

Fixed today in 2.5.1.38521:

image

Using a 3.70 sword, we can see a normal swing at 34.621 and then a Hamstring cast at 37.569 which proc'd Sword Specialization. The next normal swing occurs at 38.325 which is 3.704s after the previous normal swing, meaning the swing timer was unaffected by the extra attack.