magey / tbc-warrior

10 stars 1 forks source link

Threat values #4

Open viliustank opened 3 years ago

viliustank commented 3 years ago

Check threat values:

Cleavis commented 3 years ago

hopefully straightforward to test with the wow classic threat API, but some external reference from the EJ TBC Protection Warrior Guide:

Battle Shout +69 (rank 8) - divided amongst targets Cleave +130 (rank 6) - divided amongst targets Commanding Shout +68 - divided amongst targets Demoralizing Shout +56 (rank 7) - divided amongst targets Devastate +106 + [14 * Sunder Count] Also applies Sunder Armor threat when increasing the debuff stack Disarm +104 Hamstring +181 (rank 4) Heroic Strike +196 (rank 10) Revenge +201 (rank 8) Improved Revenge (Stun) +25 Shield Bash +230 (rank 4) Improved Shield Bash +?? Shield Slam +307 (rank 6) Sunder Armor +301 (rank 6) Taunt Sets threat equal to NPC's primary target (Section VII e.) Thunder Clap Base threat is 1.75x damage done

Battle Shout r8 (threat = 69) in the reference follows the buff threat template from classic wow of (threat generated) = (level learned), which is promising.

viliustank commented 3 years ago

Some preliminary results for threat

Bloodrage appears bugged, seems like the initial rage gain should be affected by stance modifier. Stance modifier is correctly affecting the 2 rage per second component. I can't submit a bug report on this account so someone else feel free to do it.

Feel free to repeat these tests to verify! Of course most of this will have to be repeated at 70 with higher ranks but at least gives us a baseline for the mechanics.

viliustank commented 3 years ago

Some additional info:

Cleavis commented 3 years ago

https://github.com/magey/tbc-warrior/wiki/Threat-Values

Think we both looked at some of the same things. We should merge the various ranks into one table. +Need lvl 70 to fill out the remainder.

Couldn't say if bloodrage behavior is a bug - it has always been a bit wonky with the two components (initial vs ticks) working differently.