magey / tbc-warrior

10 stars 1 forks source link

Devastate damage ramp-up is inconsistent #48

Open magey opened 3 years ago

magey commented 3 years ago

While testing Devastate I ran into an inconsistency in its damage application. Taking into account that the tooltip has the values in reverse (see #47) and calculating the correct values for Devastate rank 1 (50% weapon damage + 15 per application of sunder on the target) on an unarmored target yields (before any rounding by the game):

Sunders Damage min Damage max
0 63.89428571 64.99428571
1 80.39428571 81.49428571
2 96.89428571 97.99428571
3 113.3942857 114.4942857
4 129.8942857 130.9942857
5 146.3942857 147.4942857

The formula used is ((AP/14*2.4+Weapon_Damage)*50% + Sunders*15) * 110%. The test character has 666 AP, one-handed specialization, and wields a Shortsword (2-4 damage).

Testing these values in-game on a dummy that has near 0 armor:

image

We can see that our calculations are correct, but there's an anomaly in the damage that is being dealt; the 1st cast of Devastate correctly does 63 damage because there are no sunders on the target, but the 2nd cast does damage as if two sunders are on the target, and then it just linearly increases from there

Either the 1st cast should do ~80 damage because it applies the 1st sunder before doing damage or the 2nd cast should do ~80 damage because it does damage before applying the 2nd sunder. The way it works right now is inconsistent.

watchyoursixx commented 3 years ago

This may or may not be related, but I saw something similar with Scorpid Poison testing the other day.

Scorpid Poison was doing 23-24 per tick at 1 stack, each stack you would think should add 24 right? Each successive stack after the first was only adding 17-18 instead, up to the 5 total stacks. I couldn't figure out what was causing it other than just inconsistency or something wrong with stacking damage.

vigo2 commented 3 years ago

Re-tested today in live, it's still dealing damage as if 0, then 2, 3, 4, 5, and 5 charges of sunder armor are applied.