search

magey / tbc-warrior

10 stars 1 forks source link

Extra attacks #5

Open viliustank opened 3 years ago

viliustank commented 3 years ago

Verify behavior is consistent with classic vanilla:

magey commented 3 years ago

Specifically for Sword Specialization there is a patch note from 2.1.2 that reads (this was following a brief period where they tried to make sword spec procs yellow and then reverted it):

Sword Specialization: The change to Sword Specialization making its extra attacks appear in yellow has been reverted. Extra attacks will appear in white and act like any auto-attack. They will no longer reset the swing time of your weapon. Rage awarded will be calculated by damage dealt as with any normal auto-attack.

So in theory sword specialization should not reset your swing timer in 2.4.3. Couldn't find anything about WF totem in patch notes but we should definitely test that as well Windfury Totem does not proc off special attacks anymore - only white swings (it was changed without a patch note around August 2007 IIRC) so for Windfury Totem there's not much to test WRT swing resets.

viliustank commented 3 years ago

I note this as well for 2.2.0:

  • Sword Specialization: This talent’s free extra attacks can no longer trigger additional extra attacks.
magey commented 3 years ago

We should also test how items which grant extra attacks behave, such as Thrash Blade or Blinkstrike (if we can actually get one).

Bushmaniac commented 3 years ago

Sword specialization: Whilst heroic strike or cleave is queued, check if special attack proccing sword spec results in white attack or HS/Cleave.

vigo2 commented 3 years ago

Extra attacks can still be converted into HS/Cleave, just tested on PTR:

00:22:44.022 Devastator swings at Dummy 4 // OH (2.1 speed)
00:22:44.022 Devastator Melee Dummy 4 Miss
00:22:44.522 Devastator swings at Dummy 4. // MH (2.6 speed)
00:22:44.522 Devastator Melee Dummy 4 Miss
00:22:46.107 Devastator swings at Dummy 4 // OH
00:22:46.107 Devastator Melee Dummy 4 66

00:22:47.191 Devastator casts  Heroic Strike on Dummy 4 // MH (HS)
00:22:47.192 Devastator Heroic Strike Dummy 4 Dodge
00:22:48.259 Devastator gains 1 extra attacks from  Sword Specialization // from OH
00:22:48.259 Devastator swings at Dummy 4 // OH
00:22:48.259 Devastator casts  Heroic Strike on Dummy 4 // MH (HS) converting the extra attack
00:22:48.260 Devastator Melee Dummy 4 67
00:22:48.260 Devastator Heroic Strike Dummy 4 *927*

00:22:49.661 Devastator swings at Dummy 4 // MH
00:22:49.661 Devastator Melee Dummy 4 Parry
00:22:50.377 Devastator swings at Dummy 4 // OH
00:22:50.377 Devastator Melee Dummy 4 68
00:22:52.429 Devastator casts  Heroic Strike on Dummy 4 // MH
00:22:52.429 Devastator Heroic Strike Dummy 4 *908*