magey / tbc-warrior

10 stars 1 forks source link

Whirlwind offhand hits are not classified as the weapon type used #50

Open magey opened 3 years ago

magey commented 3 years ago

Whirlwind offhand hits don't seem to be registering as hits from the weapon type that you currently have equipped in the off-hand. This results in them not proccing things that are weapon-type-based like Mace Specialization or Sword Specialization. Additional tests need to be performed to see if this also results in WW off-hand hits not benefitting from weapon-specific racial expertise after expertise is fixed on the beta.

Here is an example log of me only casting Whirlwind while having a sword in the off-hand and non-sword in thee main hand. There are 294 WW offhand hits in this log (spell ID 44949) and no Sword Specialization procs. The probability of that occurring is 0.95^294 =~0.0000282%.

vigo2 commented 3 years ago

I stumbled upon https://wowwiki-archive.fandom.com/wiki/Sword_Specialization_(warrior_talent)?oldid=1552352, stating "Note that [Sword Specialization] counts Whirlwind as a single attack for chance of proc."

magey commented 3 years ago

I stumbled upon https://wowwiki-archive.fandom.com/wiki/Sword_Specialization_(warrior_talent)?oldid=1552352, stating "Note that [Sword Specialization] counts Whirlwind as a single attack for chance of proc."

That's fine, it just means you can't get more than 1 sword spec proc from a single Whirlwind cast. It's not unique to sword spec, all extra attack work like that with Whirlwind. When you have a sword in the offhand and something else in the main-hand you should still be able to proc Sword Spec once from a single Whirlwind cast assuming the offhand hit does damage.

Additionally, the WW offhand hit it doesn't proc mace spec either, and mace spec has a chance to proc on every hit (WW 4 targets with a 2H mace and you can stun all 4 of them with a single cast), but it does proc everything else pretty much like chance-on-hit weapon procs, rampage, flurry etc.

vigo2 commented 3 years ago

Re-tested on current PTR, results are unchanged (non-sword main hand, sword off-hand, 508 WW off-hand hits, 0 sword spec procs). When dual wielding swords, Whirlwind's per-cast proc chance seems to follow 1-0.95^4 ~ 18.5% rather than 1-0.95^8 ~ 33.7% (vs. 4 targets), a slightly different facet of the same problem.

vigo2 commented 3 years ago

Weapon-specific racial expertise seems to work - tested on the PTR with a level 58 human warrior, dual-wielding swords and using utilizing Weapon Mastery (-2% dodge) and Defiance (6 expertise). Vs. 60 level dummies, expected dodge is 0.25%, and expected parry is 3.25%. For 2516 WW off-hand hits, there were 3 dodges (~0.12%) and 87 parries (~3.46%). Without racial expertise, we'd expect 44 dodges (~1.75%), and 119 parries (~4.75%).