magey / tbc-warrior

10 stars 1 forks source link

Haste Potion Not Stacking w Dragonstrike #52

Open Cleavis opened 3 years ago

Cleavis commented 3 years ago

Behavior: Haste Potion overwrites Empyrean Demolisher proc (same spell as Drakefist/Dragonmaw/Dragonstrike (https://tbc.wowhead.com/spell=21165/haste))

WoWCombatLog-040621_194642.txt

4/6 19:48:17.023  SPELL_AURA_REMOVED,Player-4618-000E5FD7,"Cleavis-ClassicBetaPvE",0x511,0x0,Player-4618-000E5FD7,"Cleavis-ClassicBetaPvE",0x511,0x0,21165,"Haste",0x1,BUFF
4/6 19:48:17.023  SPELL_AURA_APPLIED,Player-4618-000E5FD7,"Cleavis-ClassicBetaPvE",0x511,0x0,Player-4618-000E5FD7,"Cleavis-ClassicBetaPvE",0x511,0x0,28507,"Haste",0x1,BUFF

Expected Behavior: These buffs should be able to be present at the same time https://youtu.be/xANhZmHsGRE?t=80

At 1:13 in the video, warrior pops a haste pot, at 1:18 he procs his BS hammer and both buffs are visible (albeit in 480p)

Thanks to Requiel @ Fight Club for finding the 2.3 reference video

watchyoursixx commented 3 years ago

I'm curious, do we know if this is only because the spell auras use the same name? Each of these below use the same "Haste" aura name, and each give haste rating.

https://tbc.wowhead.com/item=9449/manual-crowd-pummeler https://tbc.wowhead.com/item=28288/abacus-of-violent-odds https://tbc.wowhead.com/item=9423/the-jackhammer

I'm curious if it's just these 2 interactions or along the lines of a blanket "any item that adds haste rating." If someone with a 60 could get a MCP and test as well (I know it's not exactly the same as the above, but maybe related) that'd be interesting to see

Beannaa commented 3 years ago

If someone with a 60 could get a MCP and test as well (I know it's not exactly the same as the above, but maybe related) that'd be interesting to see

Canitnerd on Fight Club confirmed MCP and haste pots stack. Both items use the same "Haste" aura name. https://tbc.wowhead.com/spell=13494/haste https://tbc.wowhead.com/spell=28507/haste

unknown (1)

Scyllaqt commented 3 years ago

Blackout Truncheon is confirmed stacking with haste pot.

Base haste rating: 0 Blackout proc: 132 Blackout proc + haste pot: 532 haste pot alone: 400

youtube beta footage

magey commented 3 years ago

Dragonspine Trophy is also stacking with a haste pot (325 + 400 haste rating):

image

Cleavis commented 3 years ago

haste potion and empyrean demolisher fixed in 2.5.1.38521 image

Cleavis commented 2 years ago

Appears to be broken again in 2.5.4.42869, likely from the fix that made double Dragonstrike no longer stack

https://www.youtube.com/watch?v=uKfTYd2ZUZA&t=32s