magfest-archive / guests

Magfest band management plugin for ubersystem
GNU Affero General Public License v3.0
1 stars 1 forks source link

As a Perfomer, I want to be able to list any food allergies without having to select paying for food #42

Closed pelololoquin closed 8 years ago

pelololoquin commented 8 years ago

Currently, the food allergies section only shows up when you select paying for food. Since bands are not paying fro food, they will not be clicking the checkbox, so allergies/restrictions does not show up for them.

The way it should work is all badges linked to a band should have the text fill option for food restrictions/allergies instead of the food payment section

pelololoquin commented 8 years ago

image without checked

image

With checked

pelololoquin commented 8 years ago

This should be the field that shows image

binary1230 commented 8 years ago

There's some logic that shows/hides this field based on whether you're receiving food, maybe best to have uber check this box for performers and comps (without them being asked to pay for it), and let the rest of the logic stand as-is.

lemme look into it, 1s

binary1230 commented 8 years ago

ok maybe a better way, uber determines if you automatically get food based on:

@property
    def auto_food(self):
        return self.badge_type in [c.STAFF_BADGE, c.GUEST_BADGE]

+1's of bands are attendee badges so not in this list, however, we could probably check there via an override if this attendee is part of a group that is part of a band, and if so, they auto-get food.

pelololoquin commented 8 years ago

as long as the $20 isn't on the page for claiming the badges. Otherwise we'll get another person paying for food who doesn't need to or a group getting confused/upset about paying for food we said was included.

kitsuta commented 8 years ago

Closing as a duplicate of https://github.com/magfest/magstock/issues/74.

I will file an issue in the magprime plugin to make sure we don't overlook this for bands in that event, but this is ultimately different per event (e.g., there's no option to buy food for Prime and allergies are collected in a different way).