use relative URLs for band info

magfest-archive / guests

Magfest band management plugin for ubersystem

GNU Affero General Public License v3.0

1 stars 1 forks source link

use relative URLs for band info #49

Closed binary1230 closed 8 years ago

binary1230 commented 8 years ago

requires magfest/ubersystem#1890

Make band plugin use relative URLs for purely web-based stuff, and use the new functionality in base ubersystem to create absolute urls when we have no other choice, such as for the CSV export of band information, or email text generation.

kitsuta commented 8 years ago

You say this uses the new function in the main plugin to convert relative URLs to absolute URLs when needed, but I don't actually see that happening in the code. Was there a missed commit here?

binary1230 commented 8 years ago

It's the function build_absolute_whatever() in the csv export code

kitsuta commented 8 years ago

Ahh yes okay, I see it now.

binary1230 commented 8 years ago

renamed underlying function, and it now handles falsey inputs automatically so we don't need to worry about it.