search

magfest-archive / guests

Magfest band management plugin for ubersystem
GNU Affero General Public License v3.0
1 stars 1 forks source link

Turn "Band Info" into button to make it easier to click #69

Closed kitsuta closed 7 years ago

kitsuta commented 7 years ago

Fixes https://github.com/magfest/ubersystem/issues/2523 by cleaning up the page and making the 'band info' link a nice button.

kitsuta commented 7 years ago

Haha, ironically I changed the buttons to be bigger and the unmark button to be red to be consistent with MY styling!

I think the orange buttons are too low-contrast to use (Bootstrap why did you make the orange so bright) and small buttons are hard to read and don't save much space. I don't really mind changing it to match your styling but we should at some point actually hammer out a real style guide.

  1. For links that take you to a new page, but don't perform an action, I've been leaving those as regular anchor tags

I gotta object to this rule though. I mean, if you took this rule to its most extreme, we wouldn't have a navbar -- those are all just page links! Perhaps the amendment to this rule can be that if you have multiple links very close to each other, they should be buttons instead to prevent misclicks.

I like the idea of just moving Band Info out of that column entirely, but if we make it an anchor link we'll have two links right next to each other (because the group name links to the group's page). No, they won't do anything bad if you click the wrong one, but it'll be annoying. That being said, a link and a button look kind of dumb next to each other. Maybe it could be "Group Name" (unlinked) with a small set of buttons under it saying "Group Info / Band Info".

kitsuta commented 7 years ago

Per discussion in Slack, I think we've all agreed to use PatternFly's standards rather than roll our own: https://www.patternfly.org/