search

magfest-archive / guests

Magfest band management plugin for ubersystem
GNU Affero General Public License v3.0
1 stars 1 forks source link

Add custom, admin-friendly filenames to downloaded files #78

Closed kitsuta closed 7 years ago

kitsuta commented 7 years ago

Fixes https://github.com/magfest/bands/issues/77 by: 1) fixing a bug where the view's name was used because we forgot to provide a disposition to our file serving function, and 2) adding a custom filename to use so admins don't get the random filenames uploaded by bands (e.g., band_name_bio_pic.png vs my_best_selfie.png)

kitsuta commented 7 years ago

I'll merge this after I add a few unit tests, that normalization property is pretty obtuse so I want to make sure it actually works like how I expect (I mean, I wrote it, but you never know...). Just wanted to get this PR filed before I get back to work at 3. :)