search

magfest-archive / hotel

MAGFest hotel room management
GNU Affero General Public License v3.0
1 stars 2 forks source link

Improves performance of room assignments with additional subqueryloads #98

Closed RobRuana closed 6 years ago

RobRuana commented 6 years ago

🤞

RobRuana commented 6 years ago

The diff looks weird, but it's mostly reformatting. The functional difference is the calls to subqueryload()

earl7399 commented 6 years ago

+1 (note: whoever wrote old line #319 needs a talking to - preferably from Red of That 70's Show)

EliAndrewC commented 6 years ago

+1

(note: whoever wrote old line #319 needs a talking to - preferably from Red of That 70's Show)

Haha, it was probably me, though honestly I have no idea why I wouldn't have broken that line up like all the others.

My best guess is that I was like, "bleh, lemme just get this working and then I'll format it nicely later" and then later never came. I have noticed that one of the nice things about doing code reviews is that by forcing me to review my own changes before they go live I manage to catch a lot of stuff like that before anyone else even has a chance to look at it!

So really the ACTUAL monster here is all the people who weren't helping me out at the time by reviewing my code :P That's my excuse and I'm sticking to it!

earl7399 commented 6 years ago

buncha jerks!