Closed kitsuta closed 6 years ago
I'm fine with that! However, the use of email
by the automated emails server is a little obscured... I'd have to look to see how I can have it use emails
instead.
FWIW, I did a quick search of studio.email
and then game.email
(which is the only thing that uses studio.email) and the only thing I found using it was an export to CSV function, which doesn't break from this. That's not a complete guarantee there's no other place this is used, though, since it does rely on standard naming conventions.
Looks like it's here: https://github.com/magfest/ubersystem/blob/master/uber/automated_emails_server.py#L159
I'm thinking changing that is more likely to cause more unexpected behavior than changing this property.
I went ahead and did a full search for any place in the MIVS plugin that said email
. While doing this, I noticed that the CSV export I mentioned exports a Primary Contact name and email together, so I went ahead and changed that to just use primary_contact.email
. There's no other place in the code that references the game.email
or studio.email
property.
I mean, I would definitely prefer them to be named properly! But... the email server is kind of a black box to me and I don't want to mess it up. 😰
Ugh, yes, you are correct. Pluarlizing the property name would require a much deeper change ☹️
I take it all back!
The system was randomly selecting one of the contacts in a studio to send all emails to, causing confusion. Now anyone who's marked as receiving emails will get them, though they'll still be addressed to only one person.