Judging_Reminder_2017

[ultimatelyoctopuses]

I agree with the changes! Thank you so so so much!

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon Virus-free. www.avast.com https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=link <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Wed, Oct 25, 2017 at 9:57 PM, Rob Ruana notifications@github.com wrote:

@RobRuana requested changes on this pull request.

Looks good! Thanks for the contribution!

I have two minor change requests listed in the comments below. Or, if you prefer, I can make the changes for you.

If I don't hear back from you by tomorrow afternoon, I'll probably go ahead and make the changes and merge this.

Thanks again! 😄

In mivs/templates/emails/judging_reminder.txt https://github.com/magfest/mivs/pull/125#discussion_r147030043:

-{% if judge.judging_complete %}Our records indicate that you've completed reviews of all of games you've been assigned. Thanks! Please let us know if you're available to judge any additional games if any other judges find themselves unable to do so.{% else %}Our records indicate that you have completed judging on {{ judge.game_reviews|length }} games, out of the {{ judge.game_reviews|length }} you have been assigned. Please try to get the remainder evaluated before the deadline, and if you don't think you'll be able to do so, please let us know so that we can assign those games to another judge.{% endif %} +{% if judge.judging_complete %}Our records indicate that you've completed reviews of all of games you've been assigned. Thanks! Please let us know if you're available to judge any additional games, as some other judges may find themselves unable to do so.{% else %}Our records indicate that you have completed judging on {{ judge.game_reviews|length }} games, out of the {{ judge.game_reviews|length }} you have been assigned. Please try to get the remainder evaluated before the deadline, and if you don't think you'll be able to do so, please let us know so that we can assign those games to another judge.{% endif %}

I think the second {{ judge.game_reviews|length }} should be {{ judge.reviews|length }}. Looks like that was maybe an existing bug, but we should probably fix it while we're making changes here!

In mivs/templates/emails/judging_reminder.txt https://github.com/magfest/mivs/pull/125#discussion_r147030191:

-{% if judge.judging_complete %}Our records indicate that you've completed reviews of all of games you've been assigned. Thanks! Please let us know if you're available to judge any additional games if any other judges find themselves unable to do so.{% else %}Our records indicate that you have completed judging on {{ judge.game_reviews|length }} games, out of the {{ judge.game_reviews|length }} you have been assigned. Please try to get the remainder evaluated before the deadline, and if you don't think you'll be able to do so, please let us know so that we can assign those games to another judge.{% endif %} +{% if judge.judging_complete %}Our records indicate that you've completed reviews of all of games you've been assigned. Thanks! Please let us know if you're available to judge any additional games, as some other judges may find themselves unable to do so.{% else %}Our records indicate that you have completed judging on {{ judge.game_reviews|length }} games, out of the {{ judge.game_reviews|length }} you have been assigned. Please try to get the remainder evaluated before the deadline, and if you don't think you'll be able to do so, please let us know so that we can assign those games to another judge.{% endif %}

Also "reviews of all of games you've been assigned" should be "reviews of all the games you've been assigned".

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/magfest/mivs/pull/125#pullrequestreview-72060959, or mute the thread https://github.com/notifications/unsubscribe-auth/AUVjph3YFIw22MLaFGyyxWxJE_mMAqgAks5sv-cOgaJpZM4QG5UC .

[RobRuana]

FYI, this change is now live!