search

magfest-archive / ubersystem-puppet

A puppet module that manages install/config for the Magfest ubersystem registration system
3 stars 1 forks source link

'guest' plugin puppet module errors when no directory named 'bands' present #177

Closed binary1230 closed 6 years ago

binary1230 commented 6 years ago

some of the special-case logic that we added which handles the rename of the 'bands' plugin to 'guests' is error'ing out when a directory named 'bands' doesn't exist

This is repro'able with a fresh deploy, but also I am guessing it'll probably happen if we delete the 'guests' and 'bands' plugin dirs and re-run a deploy.

specific line that errors:

Error: /Stage[main]/Uber::Plugin_guests/File[/home/vagrant/uber/sideboard/plugins/guests]: Could not evaluate: Could not retrieve information from environment production source(s) file:///home/vagrant/uber/sideboard/plugins/bands, file:///home/vagrant/uber/sideboard/plugins/guests

which is https://github.com/magfest/ubersystem-puppet/blob/master/manifests/plugin_guests.pp#L40

this blocks new users from doing a deploy

RobRuana commented 6 years ago

The puppet deploy will succeed if EITHER the "guests" OR the "bands" directory exist, but it will fail if they are both missing. That explains why the deploy still works in production, which no longer has a "bands" directory.