magfest / magstock

Plugin to implement magstock-specific logic
1 stars 3 forks source link

Fix waiver form behavior on all pages #155

Closed kitsuta closed 5 years ago

kitsuta commented 5 years ago

Fixes a bug in https://jira.magfest.net/browse/MAGDEV-430 where attendees would erroneously be asked to re-sign the waiver when updating their information.

This pull request undoes several prior commits: https://github.com/magfest/magstock/commit/8313c2603b3a6eb0c2017e3db4890092ae4ff3a2, https://github.com/magfest/magstock/commit/2361a8ab19f6d9110666b51344ef1cc8b1a5a8b8, https://github.com/magfest/magstock/commit/3869c4d5121f1b25984fa59bfd3c824a13bb0332, https://github.com/magfest/magstock/commit/34bd4939e8d1f334247cab742dcbd7d7b76c5ccd, https://github.com/magfest/magstock/commit/5ba407b27f2be6ede1f34440f6dd680b13e4bae8, https://github.com/magfest/magstock/commit/89649d56b59badfb760a09501365ab0e7e4b7ef5: These did the wrong thing. The problem was the model check that tried to force you to re-sign the waiver when it shouldn't have, not the waiver not being on the form or the way the date check worked.

https://github.com/magfest/magstock/commit/d37c140da268f96d85ddc1ac083b065b526e5ec6: I think I re-implemented this right, assuming the only thing that changed is the label for the printed badge name. In general, we never want to copy regform.html into an event plugin, as it has so much logic we need it in sync with the core plugin.

https://github.com/magfest/magstock/commit/28913c1855dcf66e462fe1593117a7e779068acd: I'll fix this in the core plugin so it never prints the supporter deadline if it's the same as the shirt deadline.