magfest / ubersystem

MAGFest's Ubersystem - handles ticketing, staffing, analytics, volunteers, and tons more
http://magfest.org
GNU Affero General Public License v3.0
47 stars 54 forks source link

"Merch Booth" admin page needs to be updated to reflect staff t-shirt changes #3052

Open RobRuana opened 6 years ago

RobRuana commented 6 years ago

The "Merch Booth" admin page needs to be updated to account for several workflow changes:

  1. Staff merch will be a separate booth from attendee merch, so we need: a. A new column to indicate the difference between got_merch and got_staff_merch b. UI changes to differentiate staff merch from supporter merch
  2. The staff shirt preference should be reflected in the UI (2 staff shirts vs 1 staff shirt & 1 event shirt)
  3. The supporter levels should also list the individual merch items included with each level

Page that needs updates: https://github.com/magfest/ubersystem/blob/master/uber/templates/registration/merch.html

@EliAndrewC would this be considered follow-on work to your staff shirt preference changes?

RobRuana commented 6 years ago

Tagging @nickthenewbie1

EliAndrewC commented 6 years ago

@EliAndrewC would this be considered follow-on work to your staff shirt preference changes?

Sure, I can totally take this on. I'll try to get this knocked out over the weekend.

RobRuana commented 6 years ago

My hero!

nickthenewbie1 commented 6 years ago

I was going to list the requirements, but rob actually got most of it already there! Only other things I can think of:

EliAndrewC commented 6 years ago

Random question as I'm working on this (should have a PR up tonight): is it intentional that we no longer pre-sell tshirts? I went to the preregistration form at https://super2018.uber.magfest.org/uber/preregistration/form and there's no way to buy a tshirt when you preregister that I can see.

Was that intentional? I'm guessing it was and I just missed that PR when it went by or something, but I figured it was worth asking.

RobRuana commented 6 years ago

I have no idea if that's intentional or not. I have no memory of making any changes that would cause that. Without looking at the code, the only thing I can think of is it might have something to do with shirt_deadline.

EliAndrewC commented 6 years ago

Ahh, good call - it looks like that is what's happening from looking at the code. I don't remember that change being made, but it makes sense, since we've already ordered our tshirts and so this ensures that we don't accidentally sell more tshirts in a particular size than we have in stock.

RobRuana commented 6 years ago

Also, this was reported on slack:

screenshot_20171230-023417 screenshot_20171230-023431

nickthenewbie1 commented 6 years ago

That's correct. The listing of the 2 shirts on the uber record is because that's a hardcoded value, along with the rest of the staffer perks. It needs to be adjusted to match the staffer's actual suggestion.

On Mon, Jan 1, 2018 at 3:09 PM, Rob Ruana notifications@github.com wrote:

Also, this was reported on slack:

[image: screenshot_20171230-023417] https://user-images.githubusercontent.com/2592431/34452305-4e38f390-ed0a-11e7-8b90-1d0e13085090.png [image: screenshot_20171230-023431] https://user-images.githubusercontent.com/2592431/34452306-4e449d58-ed0a-11e7-95ef-471f95572e40.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/magfest/ubersystem/issues/3052#issuecomment-354673471, or mute the thread https://github.com/notifications/unsubscribe-auth/AHeI0dOD81bODOGJXx8RFDufD04Y5GhBks5tGTtsgaJpZM4RHtEM .

-- Nicholas Marinelli Executive Director MAGFest, Inc. www.magfest.org my pronouns are he, him, his.