search

magfest / ubersystem

MAGFest's Ubersystem - handles ticketing, staffing, analytics, volunteers, and tons more
http://magfest.org
GNU Affero General Public License v3.0
48 stars 55 forks source link

feature request: badge ordering consistency checks #508

Open binary1230 opened 10 years ago

binary1230 commented 10 years ago

an issue we just had is that somehow a staff badge for 8.5 got assigned a number outside it's valid range, and then all staff badges from that point onwards were created based on this invalid badge to find their "next badge number"

we should create a check that runs as a daemon every once in a while that runs through all the badges in the system and sanity checks that they are in order. it could email us and alert us that something is off, and we could potentially find any badge related bugs sooner.

kitsuta commented 10 years ago

This isn't getting done before 8.5, so I vote we take the tag off. It's not unique to 8.5 anyway.

kitsuta commented 10 years ago

That button I just clicked was not the "cancel comment" button. Oops.

binary1230 commented 9 years ago

quick note: badge consistency checks were added in here: https://github.com/magfest/ubersystem/blob/master-magfest85/uber/site_sections/utility.py

this was never merged in, we should merge that in at some point.

binary1230 commented 9 years ago

and here; https://github.com/magfest/ubersystem/blob/master-magfest85/uber/templates/utility/badge_number_consistency_check.html

kitsuta commented 9 years ago

The badge numbering code has been completely rewritten since this issue. I'd also like to suggest that we need to catch this kind of problem way before it gets to the point where we need a daemon checking badge numbers. :) Regardless, we ran all of Anthrocon without any badge numbering issues - even when it hit the top of the badge range for Staff badges, they were all assigned the last number, which is ideal behavior for that situation. @binary1230 do you think we can close this out?

binary1230 commented 9 years ago

ehhhhhh this is still one of the class of things I'd like to have consistency checks for. I'm fine if we could relegate this one to 'wishlist' or something. we got burned pretty hard a while ago by it pre-8.5, and the consistency check was nice to make sure my DB fixup code was working well.

thaeli commented 9 years ago

+1, wish list and keep

I like consistency checks. We should have lots of them. Even if it's a manual "database verify" or something.. Lots of overlap with a robust test suite anyway.

On Aug 10, 2015, at 4:37 PM, Dominic Cerquetti notifications@github.com wrote:

ehhhhhh this is still one of the class of things I'd like to have consistency checks for. I'm fine if we could relegate this one to 'wishlist' or something. we got burned pretty hard a while ago by it pre-8.5, and the consistency check was nice to make sure my DB fixup code was working well.

— Reply to this email directly or view it on GitHub.