search

maggienj / ActiveData

Provide high speed filtering and aggregation over data
Mozilla Public License 2.0
0 stars 0 forks source link

Fix `meta.py`: Return to size: 0, or equivalent #33

Open klahnakoski opened 7 years ago

klahnakoski commented 7 years ago

meta.py is now using size: 1, but we should find the proper way to make this query when we do not want any records. Maybe, removing the size property completely?

               "query": {
                   "match_all": {}
               },
               "size": 1
maggienj commented 7 years ago

There are several occurrences of size:1 in meta.py . First trying to remove it just in this query , in one occurrence.

maggienj commented 7 years ago

Removed another occurrence... else: result = self.default_es.post("/" + es_index + "/_search", data={ "aggs": {c.names["."]: _counting_query(c)} })

from the above block and all the unitTests in TestBasicRequests passed.

maggienj commented 7 years ago

Oh well, instead of removing them, brought them back and made them to size: 0 in all instances. all the unitTests in TestBasicRequests passed. Will have to try to run all unitTests, instead of just this one category.

maggienj commented 7 years ago

Ran all tests. (with size:0 in all occurrences in meta.py) 103 passed. 99 Fld. 22 not started.