maggienj / ActiveData

Provide high speed filtering and aggregation over data
Mozilla Public License 2.0
0 stars 0 forks source link

Reverting elasticsearch.py #42

Open klahnakoski opened 7 years ago

klahnakoski commented 7 years ago

During our initial changes, breakage was introduced to code paths responsible for old version of ES.

Use SourceTree to see all the changes made between branch es5, and master branch. Be sure the code for old version of ES is not changed.

klahnakoski commented 7 years ago

image

klahnakoski commented 7 years ago

The above shows code that switches for ESv5+, which is good. It also shows the old ESv1.x code changed from filtered to bool, which should not have happened.

klahnakoski commented 7 years ago

The same happened to pyLibrary/queries/es09/* When diff'ing master and es5 there should be no differences