search

magic-akari / seamless-scroll-polyfill

Scroll Behavior polyfill
https://www.npmjs.com/package/seamless-scroll-polyfill
MIT License
159 stars 12 forks source link

feat: add configuration to force polyfill's use #136

Closed jkrehm closed 2 years ago

jkrehm commented 2 years ago

This lets consumers test & debug in a browser of his/her choosing and not be limited to those that require the polyfill.

magic-akari commented 2 years ago

If you really want to force apply polyfill, I prefer pass it as polyfill config.

jkrehm commented 2 years ago

Sounds good, I can do that. I went with this method because it's what the polyfill that this repo is forked from does. I'll look at updating my PR soon.

magic-akari commented 2 years ago

Sounds good, I can do that. I went with this method because it's what the polyfill that this repo is forked from does. I'll look at updating my PR soon.

Of course, no hurry.

jkrehm commented 2 years ago

Updated. Mine looks similar to your closed PR. If you'd rather go with yours, that sounds good to me.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: