magic-akari / seamless-scroll-polyfill

Scroll Behavior polyfill
https://www.npmjs.com/package/seamless-scroll-polyfill
MIT License
159 stars 11 forks source link

Latest update breaks import #147

Closed mockdeep closed 1 year ago

mockdeep commented 1 year ago

When we upgrade from 2.3.0 → 2.3.3 we are no longer able to use seamless-scroll-polyfill. We've got the same lines as in the readme, but it breaks in both Chrome and Firefox on the polyfill() line. The output isn't very clear, but the error that comes back is Uncaught TypeError: Object(...) is not a function. We're using Webpack for compilation. It looks like polyfill is getting imported as undefined.

Uncaught TypeError: Object(...) is not a function
    at ./app/javascript/packs/application.ts (application.ts:3:1)
    at __webpack_require__ (bootstrap:63:1)
    at 0 (log.js:48:1)
    at __webpack_require__ (bootstrap:63:1)
    at bootstrap:198:1
    at bootstrap:198:1
magic-akari commented 1 year ago

webpack is more complicated than I thought.

I will fix this soon.

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 2.3.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

mockdeep commented 1 year ago

Great, it works, thanks!