search

magic-lang / rock

ooc compiler written in ooc
http://ooc-lang.org/
MIT License
14 stars 4 forks source link

GC is turned off by default #30

Closed thomasfanell closed 8 years ago

thomasfanell commented 8 years ago

@fredrikbryntesson peer review?

fredrikbryntesson commented 8 years ago

What happens now if you compile with gc=off?

thomasfanell commented 8 years ago

@fredrikbryntesson gc=off has no effect

thomasfanell commented 8 years ago

I left it in there, since there might be cases where one wants to be explicit about the command line

thomasfanell commented 8 years ago

Perhaps we should remove everything related to GC, since we'll never use it.

fredrikbryntesson commented 8 years ago

If we run gc=off this code will execute: params undefineSymbol(BuildParams GC_DEFINE) in rock/frontend/CommandLine.ooc . Could this create any problems now when BuildParams GC_DEFINE is not defined?

thomasfanell commented 8 years ago

@fredrikbryntesson No, undefineSymbol performs an indexOf before attempting to remove. It's perfectly safe.

fredrikbryntesson commented 8 years ago

Great