Override function definition fix

[thomasfanell]

We want to prevent this from compiling:

Foo: abstract class <T> {
    test: abstract func (value: T) -> Int
}
Bar: class <T> extends Foo<T> {
    init: func
    // this will currently compile just fine...
    test: override func (value: T*) -> Int {
        1337
    }
}
bar := Bar<Int> new()

@shamanas @zhaihj The fix works as expected, but is it too sloppy or plain naive? Suggestions?

[marcusnaslund]

Does this also prevent when T or T* is inside a Func given as argument?

[thomasfanell]

@marcusnaslund it does now :)

This will generate an error now:

Foo: abstract class <T> {
    test: abstract func (value: T, fn: Func(T) -> Int) -> Int
}
Bar: class <T> extends Foo<T> {
    init: func
    test: override func (value: T, fn: Func(T*) -> Int) -> Int {
        fn(value&)
    }
}
bar := Bar<Int> new()

[marcusnaslund]

Excellent. :)

[alexnask]

Personally I think it's fine, although I do think algo/typeAnalysis.ooc should have tools to help with this kind of thing (but iirc there is nothing about generics in there).

[thomasfanell]

@shamanas thanks, I think we'll settle with this for now then.

[thomasfanell]

Merged via #61