magic-research / piecewise-rectified-flow

PeRFlow: Piecewise Rectified Flow as Universal Plug-and-Play Accelerator
BSD 3-Clause "New" or "Revised" License
362 stars 22 forks source link

Change in the behavior of get_window_alpha in scheduler_perflow.py #7

Closed feifeiobama closed 1 month ago

feifeiobama commented 1 month ago

Hi there,

First, congratulations on releasing such an easy-to-use codebase!

I recently upgraded the codebase from 9bfc04 to the latest version, but encountered a change in the behavior of get_window_alpha:

I am wondering which is the right one for SD 1.5 with epsilon prediction.

HanshuYAN commented 1 month ago

Hi, Thanks for your interest in our work. This issue comes from here: https://github.com/magic-research/piecewise-rectified-flow/blob/c530cf76e54587ab85f0c6d00b9bca54d055da03/src/scheduler_perflow.py#L312

In the previous version, we did not rescale the timestep into the range of [0,1] before passing to get_window_alpha.

feifeiobama commented 1 month ago

Got it, thanks!