magic-script / magic-script-components

MagicScript Component Framework
https://components.magicscript.org/
Apache License 2.0
21 stars 2 forks source link

New API alignment #308

Closed ghost closed 4 years ago

ghost commented 4 years ago

Thank you for your contribution to MagicScript Project. Before submitting this PR, please make sure:

codecov-commenter commented 4 years ago

Codecov Report

Merging #308 into master will decrease coverage by 1.31%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #308      +/-   ##
===========================================
- Coverage   100.00%   98.68%   -1.32%     
===========================================
  Files           21       49      +28     
  Lines          226      304      +78     
  Branches        19       25       +6     
===========================================
+ Hits           226      300      +74     
- Misses           0        4       +4     
Impacted Files Coverage Δ
src/components/dropdown-list.js 100.00% <ø> (ø)
src/components/types/transform-node.js 100.00% <ø> (ø)
src/components/video.js 100.00% <ø> (ø)
src/internal-properties.js 100.00% <ø> (ø)
src/properties-mapping.js 100.00% <ø> (ø)
src/components/circle-confirmation.js 100.00% <100.00%> (ø)
src/components/color-picker.js 100.00% <100.00%> (ø)
src/components/components.js 100.00% <100.00%> (ø)
src/components/date-picker.js 100.00% <100.00%> (ø)
src/components/dropdown-list-item.js 100.00% <100.00%> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90f6de2...df97db7. Read the comment docs.

kpiascik commented 4 years ago

@SPaluchiewiczSofomo so I'm looking at the code coverage and see that we don't include the types or util folders. Can you add them in a follow up patch for coverage numbers. I'm ok with coverage dropping since I don't know/expect them to be covered right now.